geido commented on code in PR #34067:
URL: https://github.com/apache/superset/pull/34067#discussion_r2194755068
##########
superset-frontend/src/pages/ChartList/index.tsx:
##########
@@ -774,10 +774,17 @@ function ChartList(props: ChartListProps) {
if (canCreate) {
subMenuButtons.push({
name: (
- <>
+ <span
Review Comment:
The whole SubMenu component has a few debatable implementation choices
currently. The same indirection is there for `tabs`. This `name` property
accepting a node is also weird as `name` does not really feel like the right
property.
I think what we really want as a bare minimum right now is to avoid more
fragmented custom styles at the implementation level. I see that inside
`SubMenu` the `Button` component accepts an `icon` prop as well. Wouldn't that
cover this use case and if we still have a problem then maybe it is something
to fix at the `Button` component level instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
