EnxDev commented on PR #34067: URL: https://github.com/apache/superset/pull/34067#issuecomment-3079035479
> > > about box-shadow, I'd vote for keeping Superset vanilla antd, and if we decide to change the default style of buttons to not have box-shadow, I'd do it in the default's theme definition, no in the component. > > > By unsetting `box-shadow` in the Button component here, I think you're preventing anyone for having any shadow while they'd be trying to add a shadow by specifying they want shadow in their theme. > > > > > > Thanks for your comment, I agree with you that the best approach is to define it within the theme definition. Personally, in this case, I vote to remove the box-shadow from the button because I don't like this inconsistency. > >  > > I'm wondering whether this should apply only to the primary variant. > > @kasiazjc what do you think about that? > > I agree with you @EnxDev! And I think it should apply to all for consistency For now, while we decide which button variants to keep, I'm leaving this change in place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
