mistercrunch commented on code in PR #34067:
URL: https://github.com/apache/superset/pull/34067#discussion_r2211823299
##########
superset-frontend/src/pages/AnnotationLayerList/index.tsx:
##########
@@ -288,10 +284,10 @@ function AnnotationLayersList({
image: 'filter-results.svg',
buttonAction: () => handleAnnotationLayerEdit(null),
buttonText: (
- <>
+ <span className="ant-btn-icon">
Review Comment:
> I believe the EmptyState component could benefit from a refactor.
I did some refactoring as part of the theming branch work on that component,
but there's still a lot to untangle in that area. It looked like a manifesto on
how to misuse react in every way possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]