msyavuz commented on code in PR #34067:
URL: https://github.com/apache/superset/pull/34067#discussion_r2209985221
##########
superset-frontend/src/pages/AnnotationLayerList/index.tsx:
##########
@@ -288,10 +284,10 @@ function AnnotationLayersList({
image: 'filter-results.svg',
buttonAction: () => handleAnnotationLayerEdit(null),
buttonText: (
- <>
+ <span className="ant-btn-icon">
Review Comment:
That might lead to some code duplication, since the Button would be same
everywhere. We can maybe pass another prop like buttonIcon instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
