Re: [PR] style(Button): Vertically align icons across all buttons [superset]

Mon, 21 Jul 2025 07:53:17 -0700 


korbit-ai[bot] commented on code in PR #34067:
URL: https://github.com/apache/superset/pull/34067#discussion_r2219462627


##########
superset-frontend/packages/superset-ui-core/src/components/Button/index.tsx:
##########
@@ -120,7 +120,7 @@ export function Button(props: ButtonProps) {
         display: 'inline-flex',
         alignItems: 'center',
         justifyContent: 'center',
-        lineHeight: 1.5715,
+        lineHeight: 0,

Review Comment:
   ### Text Collapse Due to Zero Line Height <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Setting lineHeight to 0 may cause text content in buttons to collapse and 
become unreadable.
   
   
   ###### Why this matters
   While this change aims to fix icon alignment, it breaks the text rendering 
functionality of buttons containing text content. Line height of 0 means text 
lines will have no vertical space.
   
   ###### Suggested change ∙ *Feature Preview*
   Maintain a reasonable line height that works for both icons and text. 
Restore the previous value or use a relative unit:
   ```typescript
   lineHeight: 1.5715, // Previous value
   // or
   lineHeight: '1', // Minimum reasonable value
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a749d6bb-54ca-4b53-9bdb-8c78414d1e40/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a749d6bb-54ca-4b53-9bdb-8c78414d1e40?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a749d6bb-54ca-4b53-9bdb-8c78414d1e40?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a749d6bb-54ca-4b53-9bdb-8c78414d1e40?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a749d6bb-54ca-4b53-9bdb-8c78414d1e40)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:dcf34060-5b1e-4ae4-9b9f-e58971609c7c -->
   
   
   [](dcf34060-5b1e-4ae4-9b9f-e58971609c7c)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to