mistercrunch commented on code in PR #34067:
URL: https://github.com/apache/superset/pull/34067#discussion_r2211838903
##########
superset-frontend/src/explore/components/controls/VizTypeControl/constants.tsx:
##########
@@ -33,7 +33,7 @@ export const FEATURED_CHARTS: VizMeta[] = [
{ name: VizType.Table, icon: <Icons.TableOutlined iconSize="l" /> },
{
name: VizType.BigNumberTotal,
- icon: <Icons.BigNumberChartTile />,
+ icon: <Icons.BigNumberChartTile iconSize="l" viewBox="0 0 16 14" />,
Review Comment:
NOTE: not sure how this works exactly, but assuming this icon ends up in an
`Button.icon`, I think antd's internal might adjust the icon size it receives
based on the button size props. Just pointing out it could be possibly
overridden there (?) maybe only if it's not already set (?) Not sure how it all
works but curious to clarify or check it works as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
