EnxDev commented on code in PR #34067:
URL: https://github.com/apache/superset/pull/34067#discussion_r2212906943
##########
superset-frontend/src/pages/ChartList/index.tsx:
##########
@@ -774,10 +774,17 @@ function ChartList(props: ChartListProps) {
if (canCreate) {
subMenuButtons.push({
name: (
- <>
+ <span
Review Comment:
> If it’s not already supported for the button, I think we could consider
introducing props like prependIcon and appendIcon.
PS: For completeness, I noticed that the `Ant Design Button component` uses
the iconPosition prop for this with start\end values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
