EnxDev commented on code in PR #34067:
URL: https://github.com/apache/superset/pull/34067#discussion_r2212819335
##########
superset-frontend/src/explore/components/controls/VizTypeControl/constants.tsx:
##########
@@ -33,7 +33,7 @@ export const FEATURED_CHARTS: VizMeta[] = [
{ name: VizType.Table, icon: <Icons.TableOutlined iconSize="l" /> },
{
name: VizType.BigNumberTotal,
- icon: <Icons.BigNumberChartTile />,
+ icon: <Icons.BigNumberChartTile iconSize="l" viewBox="0 0 16 14" />,
Review Comment:
The viewBox defines how much virtual space the inner drawing occupies, and
it automatically scales the content to fit the visible dimensions (width /
height) of the SVG.
In our case, the font-size determines how large the SVG container should be
(which sets its width and height).
So, if we keep the default viewBox of "0 0 24 24" and apply a font-size of
16px, we end up with a scale factor of 16 / 24 = 0.666... (about 66.7%),
meaning the drawing will not fill 100% of the box.
On the other hand, setting the viewBox to "0 0 16 16" results in 16 / 16 = 1
(100%), so the drawing will scale to fill the entire box.
- 100%
<img width="282" height="128" alt="Screenshot 2025-07-17 110713"
src="https://github.com/user-attachments/assets/92aa9ae4-d37c-4735-8d7f-04d51081e11d";
/>
- 66%
<img width="267" height="118" alt="Screenshot 2025-07-17 112259"
src="https://github.com/user-attachments/assets/b8546b5b-950c-43ea-a91a-b7d171017f0d";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
