innovark37 opened a new pull request, #36073:
URL: https://github.com/apache/superset/pull/36073
### SUMMARY
This PR addresses two main issues with the Table chart controls:
1. Layout Improvement: Enhances the visual layout of the "Entries per page",
"Search by", and "Search" controls by moving labels above inputs and adjusting
font sizes for better consistency with the table content.
2. Logic Fix: Corrects the display logic for the "Search by" control, which
was previously shown incorrectly.
Now shows the control only when both "Server pagination" AND "Search box"
options are enabled. Previously it appeared with only "Server Pagination"
enabled, which was functionally incorrect.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
<img width="914" height="398" alt="{6CD86EDE-DEB5-43A6-A6E9-8DCAE646EF91}"
src="https://github.com/user-attachments/assets/bd67f489-873f-4297-8858-beadcfe98e74";
/>
<img width="435" height="389" alt="{732BE048-39F7-4C1A-BE23-32BB03912220}"
src="https://github.com/user-attachments/assets/ced25015-d971-40e3-8b5e-1282d766ca88";
/>
AFTER
<img width="909" height="402" alt="{CB6E1527-7AF3-4531-BA99-74EB3E399D37}"
src="https://github.com/user-attachments/assets/f99ce0de-0b7a-45ba-947c-5035bac365dc";
/>
<img width="426" height="387" alt="{777EACB7-9D6E-451C-A6BF-39E3E980C67D}"
src="https://github.com/user-attachments/assets/212dd603-21cf-4060-97be-2627e9f9d167";
/>
### TESTING INSTRUCTIONS
1. Create or open existing Table Chart
2. Enable only "Server pagination" option -> "Search by" should NOT appear
3. Enable only "Search box" - "Search by" should NOT appear
4. Enable both "Server pagination" AND "Search box" - "Search by" SHOULD
appear
5. Add the chart to a dashboard
6. Verify that all control labels appear above their inputs
7. Confirm font sizes match the table content
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
