Re: [PR] fix(table-chart): fix "Search by" control visibility and improve table controls layout [superset]

Tue, 11 Nov 2025 04:00:22 -0800 


korbit-ai[bot] commented on code in PR #36073:
URL: https://github.com/apache/superset/pull/36073#discussion_r2513975545


##########
superset-frontend/plugins/plugin-chart-table/src/DataTable/components/SearchSelectDropdown.tsx:
##########
@@ -41,10 +36,13 @@ function SearchSelectDropdown({
   searchOptions,
 }: SearchSelectDropdownProps) {
   return (
-    <StyledSelect
-      className="search-select"
+    <Select
+      css={(theme: SupersetTheme) => css`
+        width: ${theme.sizeUnit * 30}px;
+      `}

Review Comment:
   ### Missing right margin in CSS refactor <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The CSS-in-JS styling removes the right margin that was previously applied, 
potentially affecting layout spacing between components.
   
   
   ###### Why this matters
   This could cause visual layout issues where the dropdown appears too close 
to adjacent elements, breaking the intended design spacing and potentially 
making the UI look cramped or misaligned.
   
   ###### Suggested change ∙ *Feature Preview*
   Add the missing right margin to maintain the original layout:
   
   ```typescript
   css={(theme: SupersetTheme) => css`
     width: ${theme.sizeUnit * 30}px;
     margin-right: ${theme.sizeUnit * 2}px;
   `}
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f6185fc6-02f0-4245-8644-cba99578d29e/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f6185fc6-02f0-4245-8644-cba99578d29e?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f6185fc6-02f0-4245-8644-cba99578d29e?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f6185fc6-02f0-4245-8644-cba99578d29e?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f6185fc6-02f0-4245-8644-cba99578d29e)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:1e22ee9d-25c4-412b-8d51-66cbea4387c0 -->
   
   
   [](1e22ee9d-25c4-412b-8d51-66cbea4387c0)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to