innovark37 commented on code in PR #36073:
URL: https://github.com/apache/superset/pull/36073#discussion_r2556130779
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -217,12 +216,12 @@ function SearchInput({
inputRef,
}: SearchInputProps) {
return (
- <Space direction="horizontal" size={4} className="dt-global-filter">
+ <Space direction="vertical" size={4} className="dt-global-filter">
{t('Search')}
<Input
aria-label={t('Search %s records', count)}
- placeholder={tn('%s record', '%s records...', count, count)}
Review Comment:
I see your concern but I'm not sure how showing the total record count in
the search field improves the user experience.
That number doesn't help a user with their search. Whether there are 2
records or 2 million, they can still type a query and get zero results. The
placeholder should help users search, and the total count doesn't do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
