SBIN2010 commented on code in PR #36073:
URL: https://github.com/apache/superset/pull/36073#discussion_r2519590206
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -217,12 +216,12 @@ function SearchInput({
inputRef,
}: SearchInputProps) {
return (
- <Space direction="horizontal" size={4} className="dt-global-filter">
+ <Space direction="vertical" size={4} className="dt-global-filter">
{t('Search')}
<Input
aria-label={t('Search %s records', count)}
- placeholder={tn('%s record', '%s records...', count, count)}
Review Comment:
The placeholder attribute has been removed from the Input component. This
means users will see an empty input field with no indication of how many
records are in the table. For a better user experience, I recommend leaving the
placeholder.
##########
superset-frontend/plugins/plugin-chart-table/src/DataTable/components/SearchSelectDropdown.tsx:
##########
@@ -41,10 +36,13 @@ function SearchSelectDropdown({
searchOptions,
}: SearchSelectDropdownProps) {
return (
- <StyledSelect
- className="search-select"
Review Comment:
I think that test checking is tied to this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
