AoLiGei1221 opened a new pull request, #36281: URL: https://github.com/apache/superset/pull/36281
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY According to the [issue#35141](https://github.com/apache/superset/issues/35141), the export functionality for table chart when the search box enabled and pagination is disabled has some unexpected behaviours for it. We fixed Table chart export by passing filtered rows from DataTable to TableChart using a new callback and storing them in ownState.clientView, allowing frontend exports without backend queries. Unexpected Behaviour: When the search box is enabled, it will export all data if we do export .CSV, Excel, .JSON Expected Behaviour: We should export the data appeared in the current view (i.e. filtered data) ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF The before screenshot can be checked in [issue#35141](https://github.com/apache/superset/issues/35141). More details in the issue page. The after screenshot: <img width="356" height="67" alt="截屏2025-11-25 23 08 18" src="https://github.com/user-attachments/assets/51fb21b8-2f12-4c71-8a2e-5c914acf0cba"; /> <img width="329" height="106" alt="截屏2025-11-25 23 08 30" src="https://github.com/user-attachments/assets/0c10b237-6bd9-4de7-b922-1aa8d9c39e66"; /> <img width="564" height="261" alt="截屏2025-11-25 23 08 52" src="https://github.com/user-attachments/assets/33061037-e4fc-4351-896e-56ad0f65fe63"; /> ### TESTING INSTRUCTIONS 1. Click the **Charts** on the top of the superset page 2. Open an existing table chart or create a chart with type **Table**. 3. Click "Customize" and turn on the check box of "Search Box" 4. Click the "three dot" option on the right hand side of Save button. 5. Click "Data Export Options" 6. Choose the option between "Export All Data" and "Export Current View" 7. Choose your desired way to export data. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/35141#issuecomment-3577980613 - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
