codeant-ai-for-open-source[bot] commented on PR #36281: URL: https://github.com/apache/superset/pull/36281#issuecomment-3603145579
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36281/files#diff-888cc9d72e504a2c52077bddadbadbcbce423d45adffa6b53e0bd8888589a330R324-R345'><strong>Data Export Accuracy</strong></a><br>The client-side "Current View" CSV export (`downloadClientCSV`) directly stringifies cell values. For table cells that are objects (e.g., with `input`/`formatter` like those handled in `downloadClientJSON` and `downloadClientXLSX`), this can export `[object Object]` instead of the underlying value, leading to incorrect CSV content compared to JSON/XLSX and server-side exports. Consider normalizing values similarly to the JSON/XLSX paths.<br> - [ ] <a href='https://github.com/apache/superset/pull/36281/files#diff-888cc9d72e504a2c52077bddadbadbcbce423d45adffa6b53e0bd8888589a330R606-R684'><strong>Possible Bug</strong></a><br>In the "Export Current View" submenu, the JSON and Excel handlers fall back to calling `exportJson()`/`exportExcel()` without passing `ownState` when `server_pagination` is enabled or `clientView` is missing, while the CSV handler explicitly passes `ownState` in its server path. This may cause JSON/XLSX "current view" exports to ignore some client-side state (e.g., search box filters) or behave differently from the CSV export for the same menu section. It's worth verifying whether `ownState` should also be forwarded in these fallback branches.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
