rusackas commented on PR #36281: URL: https://github.com/apache/superset/pull/36281#issuecomment-3583511318
Love it! I think the change I'd want to see (at least, as of when we chatted) would be to only show this new menu option when it's relevant. We might want to just _enable_ it for charts where it's relevant, via an entry in the chart's metadata. In this case, that would be `superset-frontend/plugins/plugin-chart-table/src/index.ts`. Then it wouldn't appear for charts where it's _not_ relevant (pie chart, for example) but could be _added_ for charts where it _is_ relevant (besides this one, maybe the line chart when it has the "Data Zoom" feature enabled). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
