AoLiGei1221 commented on PR #36281: URL: https://github.com/apache/superset/pull/36281#issuecomment-3599616997
Hey @rusackas! I’ve just run the pre-commit hooks locally. Please take a look and re-run on your end when you get a chance. I noticed that mypy (main) reported a few Unused "type: ignore" warnings during git commit. Code: > mypy (main)..............................................................Failed > - hook id: mypy > - exit code: 1 > > superset/core/api/core_api_injection.py:58: error: Unused "type: ignore[assignment, misc]" comment [unused-ignore] > superset/core/api/core_api_injection.py:59: error: Unused "type: ignore[assignment, misc]" comment [unused-ignore] > superset/core/api/core_api_injection.py:60: error: Unused "type: ignore[assignment, misc]" comment [unused-ignore] > superset/core/api/core_api_injection.py:61: error: Unused "type: ignore[assignment, misc]" comment [unused-ignore] > superset/core/api/core_api_injection.py:62: error: Unused "type: ignore[assignment, misc]" comment [unused-ignore] > superset/core/api/core_api_injection.py:63: error: Unused "type: ignore[assignment, misc]" comment [unused-ignore] > superset/core/api/core_api_injection.py:64: error: Unused "type: ignore[assignment, misc]" comment [unused-ignore] > superset/core/api/core_api_injection.py:65: error: Unused "type: ignore[assignment, misc]" comment [unused-ignore] > superset/core/api/core_api_injection.py:66: error: Unused "type: ignore[assignment, misc]" comment [unused-ignore] but when I ran: `pre-commit run --all-files` everything passed successfully with no errors. I believe this should be fine since pre-commit run --all-files is consistent with the checks performed in CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
