EnxDev commented on PR #37461: URL: https://github.com/apache/superset/pull/37461#issuecomment-3822816038
> As I'm still learning the codebase, I welcome any context I might be missing. I've linked several related PRs in the description of #37396 that tackle the same or a similar issue. > > My instinct is that handling this (colnames + collabels) in the backend would be cleaner than frontend workarounds. Should we prioritze preprocessing this data upstream to simplify the frontend integration? @semohr this approach ensures consistent behavior across Dashboard View as Table, Explore results, and Drill By modals, while avoiding code duplication and extra props. @phmoraesrodrigues, does this plan make sense to you once @semohr’s PR #37396 is merged? - Remove custom label extraction logic - Use collabels from chartData directly - Update tests accordingly - Verify Drill By modal shows correct labels -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
