villebro commented on a change in pull request #8138: [typing] add typing for
superset/connectors and superset/common
URL:
https://github.com/apache/incubator-superset/pull/8138#discussion_r318889219
##########
File path: superset/connectors/base/models.py
##########
@@ -60,8 +60,8 @@ class BaseDatasource(AuditMixinNullable, ImportMixin):
perm = Column(String(1000))
sql = None
- owners = None
- update_from_object_fields = None
+ owners = [] # noqa
+ update_from_object_fields = [] # noqa
Review comment:
I would perhaps leave these as they are and let someone add the correct
types later. My motto (that I often violate :laugh ): When adding typing, don't
change logic, especially if it requires `# noqa`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
