villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r321413253
########## File path: superset/connectors/druid/models.py ########## @@ -24,13 +24,15 @@ import logging from multiprocessing.pool import ThreadPool import re +from typing import Dict, Iterable, List, Optional, Set, Tuple, Union from dateutil.parser import parse as dparse from flask import escape, Markup from flask_appbuilder import Model from flask_appbuilder.models.decorators import renders +from flask_appbuilder.security.sqla.models import User from flask_babel import lazy_gettext as _ -import pandas +import pandas as pd Review comment: 👍 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
