villebro commented on a change in pull request #8138: [typing] add typing for
superset/connectors and superset/common
URL:
https://github.com/apache/incubator-superset/pull/8138#discussion_r319226410
##########
File path: superset/common/query_context.py
##########
@@ -150,8 +155,8 @@ def cache_timeout(self):
return self.datasource.database.cache_timeout
return config.get("CACHE_DEFAULT_TIMEOUT")
Review comment:
I think anything that is defined with a default value other than `None` in
`config.py` can be assumed to never return `None`. So if it helps typing, I
think going with `config[key]` is ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
