villebro commented on a change in pull request #8138: [typing] add typing for
superset/connectors and superset/common
URL:
https://github.com/apache/incubator-superset/pull/8138#discussion_r318889318
##########
File path: superset/connectors/base/models.py
##########
@@ -79,68 +79,68 @@ def slices(self):
metrics: List[Any] = []
@property
- def uid(self):
+ def uid(self) -> str:
"""Unique id across datasource types"""
return f"{self.id}__{self.type}"
@property
- def column_names(self):
+ def column_names(self) -> List[str]:
return sorted([c.column_name for c in self.columns], key=lambda x: x
or "")
@property
- def columns_types(self):
+ def columns_types(self) -> Dict:
return {c.column_name: c.type for c in self.columns}
@property
- def main_dttm_col(self):
+ def main_dttm_col(self) -> str:
return "timestamp"
@property
def datasource_name(self):
raise NotImplementedError()
@property
- def connection(self):
+ def connection(self) -> Optional[str]:
"""String representing the context of the Datasource"""
return None
@property
- def schema(self):
+ def schema(self) -> Optional[str]:
"""String representing the schema of the Datasource (if it applies)"""
return None
@property
- def filterable_column_names(self):
+ def filterable_column_names(self) -> List:
Review comment:
I'm fairly sure these are `List[str]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
