betodealmeida commented on PR #34826: URL: https://github.com/apache/superset/pull/34826#issuecomment-4383603875
@villebro @michael-s-molina thanks for the feedback. I rebased this PR on and reworked it to remove the pool mode work entirely.\n\nThis PR is now focused on consolidating engine creation into (single behavior, equivalent to previous behavior):\n- removed and all mode/cleanup config\n- removed in-memory engine/tunnel caching and background cleanup thread\n- kept the refactor that centralizes engine creation + SSH tunnel wiring\n\nSo this no longer introduces cluster-wide pooling semantics or the singleton behavior discussed above.\n\nIf we want distributed/shared pooling in the future, that should come as a separate design discussion/PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
