betodealmeida commented on PR #34826: URL: https://github.com/apache/superset/pull/34826#issuecomment-4383604368
Follow-up (previous comment had formatting issues from CLI quoting): I rebased this PR on master and reworked it to remove the pool mode work entirely. This PR is now focused on consolidating engine creation into EngineManager with a single behavior equivalent to the previous nullpool=true path. Specifically: removed EngineModes and the ENGINE_MANAGER mode/cleanup config; removed in-memory engine/tunnel caching and background cleanup thread; kept the refactor that centralizes engine creation and SSH tunnel wiring. So this no longer introduces cluster-wide pooling semantics or singleton behavior. If we want distributed/shared pooling in the future, that should come as a separate design discussion/PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
