betodealmeida commented on PR #34826: URL: https://github.com/apache/superset/pull/34826#issuecomment-4389165536
@michael-s-molina @villebro I rewrote this PR keeping the non-controversial part: centralizing the engine creation in a single class. I think there's a lot of value there already, since today the creation is scattered in the database model. This keeps the existing behavior, but opens the possibility of more complex engine managers in the future, addressing both use cases that we discussed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
