codecov[bot] commented on PR #34826: URL: https://github.com/apache/superset/pull/34826#issuecomment-4383670875
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/34826?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `68.80000%` with `39 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 55.56%. Comparing base ([`9459bc7`](https://app.codecov.io/gh/apache/superset/commit/9459bc7bf4bef8622ad342c9e7d50c6e4469e6ae?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3aad565`](https://app.codecov.io/gh/apache/superset/commit/3aad565eab9cd6eb86de11b1ca35b349a02a5ba3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/34826?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [superset/engines/manager.py](https://app.codecov.io/gh/apache/superset/pull/34826?src=pr&el=tree&filepath=superset%2Fengines%2Fmanager.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZW5naW5lcy9tYW5hZ2VyLnB5) | 55.95% | [33 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/superset/pull/34826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/extensions/engine\_manager.py](https://app.codecov.io/gh/apache/superset/pull/34826?src=pr&el=tree&filepath=superset%2Fextensions%2Fengine_manager.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy9lbmdpbmVfbWFuYWdlci5weQ==) | 90.47% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/34826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (9459bc7) and HEAD (3aad565). Click for more details. > > <details><summary>HEAD has 58 uploads less than BASE</summary> > >| Flag | BASE (9459bc7) | HEAD (3aad565) | >|------|------|------| >|hive|5|1| >|python|42|3| >|presto|4|1| >|unit|13|1| ></details> <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #34826 +/- ## ========================================== - Coverage 63.87% 55.56% -8.31% ========================================== Files 2582 2583 +1 Lines 136418 136448 +30 Branches 31454 31453 -1 ========================================== - Hits 87137 75824 -11313 - Misses 47768 59967 +12199 + Partials 1513 657 -856 ``` | [Flag](https://app.codecov.io/gh/apache/superset/pull/34826/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hive](https://app.codecov.io/gh/apache/superset/pull/34826/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.30% <68.80%> (+0.01%)` | :arrow_up: | | [mysql](https://app.codecov.io/gh/apache/superset/pull/34826/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [postgres](https://app.codecov.io/gh/apache/superset/pull/34826/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [presto](https://app.codecov.io/gh/apache/superset/pull/34826/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.01% <68.80%> (+0.01%)` | :arrow_up: | | [python](https://app.codecov.io/gh/apache/superset/pull/34826/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.28% <68.80%> (-18.26%)` | :arrow_down: | | [sqlite](https://app.codecov.io/gh/apache/superset/pull/34826/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unit](https://app.codecov.io/gh/apache/superset/pull/34826/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/34826?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
