richardfogaca opened a new pull request, #40060:
URL: https://github.com/apache/superset/pull/40060

   ### SUMMARY
   Adds an OSS-owned `chart_type_label` response field for MCP chart creation 
and explore-link results. The label is derived from the rendered Superset 
`viz_type`, so clients can use a stable user-facing description such as `table 
chart` for `table` and `interactive table chart` for `ag-grid-table` without 
duplicating chart semantics.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Not applicable; MCP response metadata only.
   
   ### TESTING INSTRUCTIONS
   - `ruff format superset/mcp_service/chart/chart_utils.py 
superset/mcp_service/chart/schemas.py 
superset/mcp_service/chart/tool/generate_chart.py 
superset/mcp_service/explore/tool/generate_explore_link.py 
tests/unit_tests/mcp_service/chart/test_chart_schemas.py 
tests/unit_tests/mcp_service/chart/test_chart_utils.py 
tests/unit_tests/mcp_service/explore/tool/test_generate_explore_link.py`
   - `ruff check superset/mcp_service/chart/chart_utils.py 
superset/mcp_service/chart/schemas.py 
superset/mcp_service/chart/tool/generate_chart.py 
superset/mcp_service/explore/tool/generate_explore_link.py 
tests/unit_tests/mcp_service/chart/test_chart_schemas.py 
tests/unit_tests/mcp_service/chart/test_chart_utils.py 
tests/unit_tests/mcp_service/explore/tool/test_generate_explore_link.py`
   - `PYENV_VERSION=superset pre-commit run --files 
superset/mcp_service/chart/chart_utils.py superset/mcp_service/chart/schemas.py 
superset/mcp_service/chart/tool/generate_chart.py 
superset/mcp_service/explore/tool/generate_explore_link.py 
tests/unit_tests/mcp_service/chart/test_chart_schemas.py 
tests/unit_tests/mcp_service/chart/test_chart_utils.py 
tests/unit_tests/mcp_service/explore/tool/test_generate_explore_link.py`
   
   Note: focused pytest could not start in my local checkout because the 
environment is missing `superset_core.semantic_layers`. The pre-commit run 
passed through ruff, mypy, and other file checks but failed at the pylint hook 
on existing configuration/baseline issues outside this change (`.pylintrc` 
unknown `json-import`, `superset/db_engine_specs/base.py` transaction warning).
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to