Copilot commented on code in PR #40060:
URL: https://github.com/apache/superset/pull/40060#discussion_r3226548072
##########
superset/mcp_service/explore/tool/generate_explore_link.py:
##########
@@ -243,6 +244,7 @@ async def generate_explore_link(
"url": explore_url,
"form_data": form_data,
"form_data_key": form_data_key,
+ "chart_type_label":
get_table_chart_type_label(form_data.get("viz_type")),
"error": None,
}
Review Comment:
The success response now includes `chart_type_label`, but the other return
paths in this tool (dataset not found, access denied, validation failure,
exception handler) don’t include this key at all. That makes the response shape
inconsistent for API clients (missing vs null). Consider returning
`chart_type_label: None` in all non-success responses (and ideally for
non-table viz_types) to keep the payload schema stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
