richardfogaca commented on PR #40060: URL: https://github.com/apache/superset/pull/40060#issuecomment-4440574655
@aminghadersohi pushed follow-ups in 5e0b701 to address the review notes: - Replaced the if/elif label logic with a shared CHART_TYPE_LABELS mapping. - Kept label derivation centralized in get_table_chart_type_label, used by both generate_chart and generate_explore_link. - Added explicit None and unknown viz_type handling. - Added generate_chart path coverage for chart_type_label in addition to the existing generate_explore_link coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
