aminghadersohi commented on code in PR #40060:
URL: https://github.com/apache/superset/pull/40060#discussion_r3235854280
##########
superset/mcp_service/chart/chart_utils.py:
##########
@@ -1212,6 +1212,19 @@ def _resolve_viz_type(config: Any) -> str:
return "unknown"
+CHART_TYPE_LABELS = {
+ "table": "table chart",
Review Comment:
NIT: The name `CHART_TYPE_LABELS` implies a general chart type registry, but
the function `get_table_chart_type_label` and the PR description both
explicitly scope this to table-family types only. A name like
`TABLE_VIZ_TYPE_LABELS` would prevent future contributors from adding non-table
labels to this dict and conflating it with the broader intent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
