Aitema-gmbh commented on code in PR #39234:
URL: https://github.com/apache/superset/pull/39234#discussion_r3232373432
##########
superset-frontend/packages/superset-core/src/theme/GlobalStyles.tsx:
##########
@@ -55,6 +55,16 @@ export const GlobalStyles = () => {
color: ${theme.colorLink};
}
+ /* WCAG 1.4.3: Minimum Contrast — override link color from
colorPrimary (#2893B3,
+ 3.55:1 on white) to a darker shade that meets the 4.5:1 text
contrast threshold.
+ Excludes links that are intentionally styled as buttons. */
+ a:not([class*="ant-btn"]):not([role="button"]) {
+ color: #0d7090 !important;
+ }
+ a:not([class*="ant-btn"]):not([role="button"]):hover {
+ color: #0a5a73 !important;
+ }
Review Comment:
Addressed in 47936768 — switched from hardcoded hex values to
`theme.colorLink`/`theme.colorLinkHover` tokens, which are tuned per theme to
meet 4.5:1 against the paired `colorBgBase` (light and dark). Resolving —
thanks for the catch.
##########
superset-frontend/packages/superset-core/src/theme/GlobalStyles.tsx:
##########
@@ -55,6 +55,19 @@ export const GlobalStyles = () => {
color: ${theme.colorLink};
}
+ /* WCAG 1.4.3: Minimum Contrast — route link colors through theme
tokens
+ so they adapt to light, dark, and custom themes. The token defaults
+ (colorLink / colorLinkHover) are tuned to meet the 4.5:1 contrast
+ threshold on the paired colorBgBase; hardcoded hex values previously
+ used here were light-mode-only and failed WCAG in dark themes.
+ Excludes links that are intentionally styled as buttons. */
+ a:not([class*="ant-btn"]):not([role="button"]) {
+ color: ${theme.colorLink};
+ }
Review Comment:
Addressed in efcc335c — collapsed to a single `a { color: theme.colorLink }`
rule. The duplicate `:not(...)` selector was a no-op because AntD button-styled
anchors carry their own component-level coloring that overrides the global
rule. Resolving — thanks for the catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
