Aitema-gmbh commented on PR #39234: URL: https://github.com/apache/superset/pull/39234#issuecomment-4440802050
@rusackas heads-up — the Copilot follow-up on the default theme is now addressed in `e642f478`. The PR previously routed links through `theme.colorLink` but the default AntD token (`#1677ff`) lands at ~4.32:1 on white, so the WCAG 1.4.3 guarantee did not hold for an unconfigured Superset deployment. Fix is a small `ensureLinkContrast` helper in `Theme.setConfig` that darkens the default link tokens until 4.5:1 is reached, scoped strictly to the "neither `colorPrimary` nor `colorLink` supplied" path so explicit brand colors are left untouched. Two new unit tests cover both directions. Also rebased on master in the same push. Ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
