Aitema-gmbh commented on code in PR #39234:
URL: https://github.com/apache/superset/pull/39234#discussion_r3232374846
##########
superset-frontend/packages/superset-core/src/theme/GlobalStyles.tsx:
##########
@@ -55,6 +55,19 @@ export const GlobalStyles = () => {
color: ${theme.colorLink};
}
+ /* WCAG 1.4.3: Minimum Contrast — route link colors through theme
tokens
+ so they adapt to light, dark, and custom themes. The token defaults
+ (colorLink / colorLinkHover) are tuned to meet the 4.5:1 contrast
+ threshold on the paired colorBgBase; hardcoded hex values previously
+ used here were light-mode-only and failed WCAG in dark themes.
+ Excludes links that are intentionally styled as buttons. */
Review Comment:
Addressed in efcc335c — the comment was rewritten to remove the inaccurate
"hardcoded hex values previously used here" phrase and now explicitly states
that the 4.5:1 guarantee depends on the active theme's
`colorLink`/`colorLinkHover` tokens being tuned for the paired `colorBgBase`.
Resolving — thanks for the catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
