Aitema-gmbh commented on code in PR #39234:
URL: https://github.com/apache/superset/pull/39234#discussion_r3232372465
##########
superset-frontend/packages/superset-core/src/theme/GlobalStyles.tsx:
##########
@@ -55,6 +55,16 @@ export const GlobalStyles = () => {
color: ${theme.colorLink};
}
+ /* WCAG 1.4.3: Minimum Contrast — override link color from
colorPrimary (#2893B3,
+ 3.55:1 on white) to a darker shade that meets the 4.5:1 text
contrast threshold.
+ Excludes links that are intentionally styled as buttons. */
+ a:not([class*="ant-btn"]):not([role="button"]) {
+ color: #0d7090 !important;
+ }
+ a:not([class*="ant-btn"]):not([role="button"]):hover {
+ color: #0a5a73 !important;
Review Comment:
Addressed in 47936768 — link colors now route through
`theme.colorLink`/`theme.colorLinkHover` so custom themes and dark mode
override correctly. Resolving — thanks for the catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
