aminghadersohi commented on PR #40339:
URL: https://github.com/apache/superset/pull/40339#issuecomment-4567486940
Addressed all three points from Richard's reviews:
**Review 1 — string metric values + geojson null filter:**
1. `_resolve_deck_gl_metrics()` now preserves string-backed metrics via
`_is_metric_ref()` (line 290-304), which returns `True` for non-numeric strings
like `"count"` while excluding fixed display values like `"100"`. Fixed in
`362b9faaab`.
2. `_deck_gl_null_filters()` now includes `geojson` in the null-filter loop
(line 322-326: `for field in ("line_column", "geojson")`). Fixed in
`362b9faaab`.
**Review 2 — `point_radius_fixed` bare string for `deck_scatter`:**
3. `_resolve_deck_gl_metrics()` now handles `elif isinstance(prf, str) and
_is_metric_ref(prf)` at line 354-356, appending non-numeric string values as
metrics. Fixed in `e32a683f6f`.
All fixes are already pushed and CI is green on these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
