aminghadersohi commented on code in PR #40130:
URL: https://github.com/apache/superset/pull/40130#discussion_r3342309168
##########
superset/datasets/api.py:
##########
@@ -706,8 +717,9 @@ def refresh(self, pk: int) -> Response:
@safe
@statsd_metrics
@event_logger.log_this_with_context(
Review Comment:
**NIT — Unrelated cosmetic lambda reformats mixed into the functional diff**
The `detect_datetime_formats` action lambda was reformatted from implicit
string concatenation to parenthesized form here. The same cosmetic change was
applied to `related_objects` (~line 802), `get_or_create_dataset` (~line 1116),
and `get_drill_info` (~line 1338). None of these touch soft-delete logic. They
add diff noise and make the functional changes harder to audit during review.
Please move to a separate cleanup commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
