mikebridge commented on PR #40130:
URL: https://github.com/apache/superset/pull/40130#issuecomment-4606595502
Follow-up correction: I reverted the `down_revision` change in 42e732a1e2.
When I traced the alembic chain to verify the CI failure ("Multiple head
revisions present"), I found I'd been reading the chain inverted. Tracing each
`down_revision` link directly:
```
4b2a8c9d3e1f → a1b2c3d4e5f6 → ce6bd21901ab → 33d7e0e21daa
```
- `33d7e0e21daa.down_revision = ce6bd21901ab`
- `ce6bd21901ab.down_revision = a1b2c3d4e5f6`
- Nothing chains off `33d7e0e21daa`
So `33d7e0e21daa` is the actual master head, not `a1b2c3d4e5f6`. The
original `down_revision = "33d7e0e21daa"` was correct all along. The
file-creation dates were misleading me: `33d7e0e21daa` (filename dated
2025-11-04) was merged into master *after* the 2026-03-02 batch via a feature
branch, so the file date doesn't reflect alembic chain order.
Reverting restored the chain. CI re-running on 42e732a1e2.
Apologies for the noise on the previous round — and thanks @aminghadersohi
for flagging that the migration needed attention; the *signal* (CI would break)
was correct even though the specific cause was the inverse of what we both
concluded at the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
