mikebridge commented on PR #40130: URL: https://github.com/apache/superset/pull/40130#issuecomment-4604888720
Thanks @aminghadersohi for the re-review and confirming all prior findings closed. One follow-up pushed in ea13ca7378: **Migration `down_revision` update**: updated `3a8e6f2c1b95`'s `down_revision` from `33d7e0e21daa` to `a1b2c3d4e5f6` (the current alembic head). Without this, `alembic upgrade head` would fail with "Multiple head revisions present" once the migration lands on a database that already has master's chain. The sibling charts (#40129) and dashboards (#40128) PRs got the same update on their migrations in companion commits. Cross-PR merge-order coordination still applies — whichever lands first stays at `a1b2c3d4e5f6`, the others rebase onto the newly-merged revision. The branch was also rebased on current master in this push (the previous base was 34 commits behind preset/master; no conflicts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
