bito-code-review[bot] commented on code in PR #40130:
URL: https://github.com/apache/superset/pull/40130#discussion_r3343890010
##########
superset/datasets/filters.py:
##########
@@ -51,3 +53,10 @@ def apply(self, query: Query, value: bool) -> Query:
)
)
return query
+
+
+class DatasetDeletedStateFilter(BaseDeletedStateFilter): # pylint:
disable=too-few-public-methods
+ """Rison filter for the GET list that exposes soft-deleted datasets."""
+
+ arg_name = "dataset_deleted_state"
+ model = SqlaTable
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing type annotation on model</b></div>
<div id="fix">
Add a type annotation to the `model` attribute to match the
`BaseDeletedStateFilter` contract: declare `model:
ClassVar[type[SoftDeleteMixin]] = SqlaTable`, and import both `ClassVar` from
`typing` and `SoftDeleteMixin` from its module.
</div>
</div>
<small><i>Code Review Run #e19a98</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
