mikebridge commented on PR #40130: URL: https://github.com/apache/superset/pull/40130#issuecomment-4635194618
Re: the test-cleanup note — fixed in d66d661b36. The `TestDatasetSoftDelete` methods that soft-delete-then-restore are now wrapped in `try/finally` via a `_restore_dataset` helper, so a failed assertion can't strand a soft-deleted row into later tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
