bito-code-review[bot] commented on code in PR #40130: URL: https://github.com/apache/superset/pull/40130#discussion_r3365394144
########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -4688,6 +4688,9 @@ msgstr "L’ensemble de données n'a pas pu être créé." msgid "Dataset could not be duplicated." msgstr "L’ensemble de données n'a pas pu être dupliqué." +msgid "Dataset could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing French translation</b></div> <div id="fix"> The `msgstr` field is empty. French users will see the untranslated English error message. Based on the established translation pattern in this file (e.g., "Dataset could not be duplicated." → "L'ensemble de données n'a pas pu être dupliqué."), the correct translation should be "L'ensemble de données n'a pas pu être restauré.". </div> </div> <small><i>Code Review Run #dfa400</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/sl/LC_MESSAGES/messages.po: ########## @@ -4687,6 +4687,9 @@ msgstr "Podatkovnega niza ni mogoče ustvariti." msgid "Dataset could not be duplicated." msgstr "Podatkovnega niza ni mogoče duplicirati." +msgid "Dataset could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Slovenian translation</b></div> <div id="fix"> The `msgstr` field is empty. Slovenian-speaking users will see the untranslated English error message 'Dataset could not be restored.' instead of a localized message. Provide the Slovenian translation to ensure consistent user experience. </div> </div> <small><i>Code Review Run #dfa400</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/ja/LC_MESSAGES/messages.po: ########## @@ -4329,6 +4329,9 @@ msgstr "データセットを作成できませんでした。" msgid "Dataset could not be duplicated." msgstr "データセットを複製できませんでした。" +msgid "Dataset could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Japanese translation</b></div> <div id="fix"> The new `msgid "Dataset could not be restored."` entry has an empty `msgstr ""` in the Japanese locale. Japanese-speaking users will see the untranslated English error message instead of a localized string. All other "Dataset could not be X" messages in this file have proper Japanese translations (lines 4327, 4330, 4336). </div> </div> <small><i>Code Review Run #dfa400</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt/LC_MESSAGES/messages.po: ########## @@ -4664,6 +4664,9 @@ msgstr "Não foi possível gravar a sua query" msgid "Dataset could not be duplicated." msgstr "Não foi possível gravar a sua query" +msgid "Dataset could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Portuguese translation</b></div> <div id="fix"> The `msgstr` field is empty, so Portuguese users will see untranslated English text when this error occurs. Provide a Portuguese translation consistent with the pattern used for similar messages (e.g., 'Não foi possível gravar a sua query'). </div> </div> <small><i>Code Review Run #dfa400</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/nl/LC_MESSAGES/messages.po: ########## @@ -4720,6 +4720,9 @@ msgstr "Dataset kon niet worden aangemaakt." msgid "Dataset could not be duplicated." msgstr "Dataset kon niet worden gedupliceerd." +msgid "Dataset could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Dutch translation</b></div> <div id="fix"> The `msgstr` field is empty, so Dutch-speaking users will see untranslated English text. Following the established pattern for similar messages (e.g., "Dataset could not be duplicated." → "Dataset kon niet worden gedupliceerd."), the translation should be "Dataset kon niet worden hersteld.". </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- superset/translations/nl/LC_MESSAGES/messages.po +++ superset/translations/nl/LC_MESSAGES/messages.po @@ -4721,7 +4721,7 @@ msgstr "Dataset kon niet worden gedupliceerd." msgid "Dataset could not be restored." -msgstr "" +msgstr "Dataset kon niet worden hersteld." msgid "Dataset could not be updated." msgstr "Dataset kon niet worden bijgewerkt." ``` </div> </details> </div> <small><i>Code Review Run #dfa400</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
