mikebridge commented on PR #40130: URL: https://github.com/apache/superset/pull/40130#issuecomment-4652137709
**Latest review items addressed** (`9582bbfdc0`): - Added `assert rv.status_code == 200` on the soft-delete `DELETE` calls in the list/filter/no-cascade tests (bito CWE-483). - **Translations:** added `msgid "Dataset could not be restored."` to `messages.pot`. All language `.po` files already carry the empty-`msgstr` placeholder. Resolving the per-language translation threads as placeholder-complete. - The `get_table` catalog determinism (codeant) was fixed in `891486b615`. Resolving the corresponding threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
