mikebridge commented on PR #40129: URL: https://github.com/apache/superset/pull/40129#issuecomment-4652137593
**Latest review items addressed** (`9e4d177d29`): - Deduped the soft-delete import-test setup into a `_soft_delete_existing_chart` helper (and made its timestamp timezone-aware). - **Translations:** added `msgid "Chart could not be restored."` to `messages.pot`. Every language `.po` already has the empty-`msgstr` placeholder for translators. Resolving the per-language translation threads as placeholder-complete (actual translations come via the i18n workflow). - amin's earlier items (RBAC restore mapping, `user=None` bypass doc, inline-import justification) were addressed in prior commits. Resolving the corresponding threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
