rusackas commented on code in PR #41132:
URL: https://github.com/apache/superset/pull/41132#discussion_r3470077518
##########
superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/index.tsx:
##########
@@ -346,9 +346,9 @@ class AdhocMetricEditPopover extends PureComponent<
savedMetric: propsSavedMetric,
columns,
savedMetricsOptions,
- onChange,
- onClose,
- onResize,
+ onChange: _onChange,
+ onClose: _onClose,
+ onResize: _onResize,
Review Comment:
These three are destructured on purpose to keep them out of
`...popoverProps`, which gets spread onto a child at the bottom of `render`.
Dropping them would leak `onChange`/`onClose`/`onResize` onto that element, so
the `_`-prefix is the intended way to exclude them.
##########
superset-frontend/packages/superset-ui-core/src/components/Label/index.tsx:
##########
@@ -34,7 +34,7 @@ export const Label = forwardRef<HTMLSpanElement,
LabelProps>((props, ref) => {
onClick,
children,
icon,
- id,
+ id: _id,
Review Comment:
`id` was already destructured separately on `master` and never spread into
`<Tag>`, so it was not passing through `...rest` to begin with. The `_id`
rename just silences the rule without changing that behavior. Reverting to `id`
would start forwarding it, which is a behavior change beyond this lint flip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
