rusackas commented on code in PR #41132:
URL: https://github.com/apache/superset/pull/41132#discussion_r3470078869
##########
superset-frontend/packages/superset-ui-core/src/components/TimezoneSelector/index.tsx:
##########
@@ -66,7 +66,7 @@ function findMatchingTimezone(
export default function TimezoneSelector({
onTimezoneChange,
timezone,
- minWidth = MIN_SELECT_WIDTH,
+ minWidth: _minWidth = MIN_SELECT_WIDTH,
Review Comment:
`minWidth` was already destructured-but-unused on `master`, so the discard
predates this PR. All I did here was rename it to `_minWidth` to satisfy the
rule, behavior unchanged. Wiring it into the `<Select>` (or dropping the prop)
is a real fix, but its own change rather than part of this lint flip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
