sadpandajoe commented on code in PR #41132:
URL: https://github.com/apache/superset/pull/41132#discussion_r3478216962
##########
superset-frontend/src/dashboard/components/SaveModal.tsx:
##########
@@ -65,18 +65,18 @@ type SaveModalProps = {
function SaveModal({
saveType: initialSaveType = SAVE_TYPE_OVERWRITE,
- colorNamespace,
- colorScheme,
+ colorNamespace: _colorNamespace,
Review Comment:
Since there’s no `...rest` spread or callback-position constraint here, can
we trim `colorNamespace`/`colorScheme`/`addSuccessToast`/`expandedSlices` from
`SaveModalProps` and the `<SaveModal>` call instead of keeping `_` aliases?
Otherwise the new lint baseline still leaves compile-clean no-op props on this
component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
