bito-code-review[bot] commented on code in PR #41132:
URL: https://github.com/apache/superset/pull/41132#discussion_r3488876439
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx:
##########
@@ -141,8 +141,6 @@ const VerticalFilterBar: FC<VerticalBarProps> = ({
onPendingCustomizationDataMaskChange,
toggleFiltersBar,
width,
- clearAllTriggers,
- onClearAllComplete,
}) => {
const theme = useTheme();
Review Comment:
<!-- Bito Reply -->
The suggestion is valid in the context of maintaining a consistent interface
contract. While the props are currently unused in the child component, removing
them from the parent component ensures that the interface remains clean and
avoids passing unnecessary data, which is a standard best practice for
component maintenance.
**superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx**
```
width,
- clearAllTriggers,
- onClearAllComplete,
}) => {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
