codeant-ai-for-open-source[bot] commented on code in PR #41688:
URL: https://github.com/apache/superset/pull/41688#discussion_r3518277765
##########
superset/translations/fr/LC_MESSAGES/messages.po:
##########
@@ -4829,68 +4758,68 @@ msgid "Databases"
msgstr "Bases de données"
msgid "Dataset"
-msgstr "Ensemble de données"
+msgstr "Jeu de données"
#, python-format
msgid "Dataset %(table)s already exists"
msgstr "Le jeu de données %(table)s existe déjà"
msgid "Dataset Name"
-msgstr "Nom de l’ensemble de données"
+msgstr "Nom du jeu de données"
msgid "Dataset column delete failed."
-msgstr "La suppression de l’ensemble de données a échoué."
+msgstr "La suppression du jeu de données a échoué."
msgid "Dataset column not found."
-msgstr "Colonne de l’ensemble de données introuvable."
+msgstr "Colonne du jeu de données introuvable."
msgid "Dataset could not be created."
-msgstr "L’ensemble de données n'a pas pu être créé."
+msgstr "Le jeu de données n'a pas pu être créé."
msgid "Dataset could not be duplicated."
-msgstr "L’ensemble de données n'a pas pu être dupliqué."
+msgstr "Le jeu de données n'a pas pu être dupliqué."
msgid "Dataset could not be updated."
-msgstr "L’ensemble de données n'a pas pu être mis à jour."
+msgstr "Le jeu de données n'a pas pu être mis à jour."
msgid "Dataset does not exist"
-msgstr "L’ensemble de données n'existe pas"
+msgstr "Le jeu de données n'existe pas"
msgid "Dataset is required"
-msgstr "Un ensemble de données est requis"
+msgstr "Un jeu de données est requis"
msgid "Dataset metric delete failed."
-msgstr "La suppression de l’ensemble de données a échoué."
+msgstr "La suppression du jeu de données a échoué."
Review Comment:
**Suggestion:** This translation also maps a metric-deletion failure to
dataset deletion, which changes the meaning of the original message and gives
users the wrong failure context. Adjust it to explicitly mention metric
deletion. [comment mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
⚠️ Metric delete errors misreported as dataset deletion failures.
⚠️ Confuses maintainers during failed metric cleanup.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. In `superset/commands/dataset/metrics/exceptions.py:3-8`,
`DatasetMetricDeleteFailedError` sets its message to `_("Dataset metric
delete failed.")`.
2. The dataset metric delete API at `superset/datasets/metrics/api.py:13-27`
catches
`DatasetMetricDeleteFailedError` and returns a 422 with `message=str(ex)`,
which will be
the localized message.
3. The French catalog at
`superset/translations/fr/LC_MESSAGES/messages.po:4791-4792`
binds msgid `Dataset metric delete failed.` to msgstr `La suppression du jeu
de données a
échoué.`, omitting "metric" and referring to the whole dataset.
4. When a metric deletion fails in the dataset editor (Edit datasource >
Metrics), French
users receive an error claiming the dataset deletion failed, giving the
wrong context for
what actually failed.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=14d123e6383842daa9b07f8d044c896f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=14d123e6383842daa9b07f8d044c896f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/fr/LC_MESSAGES/messages.po
**Line:** 4792:4792
**Comment:**
*Comment Mismatch: This translation also maps a metric-deletion failure
to dataset deletion, which changes the meaning of the original message and
gives users the wrong failure context. Adjust it to explicitly mention metric
deletion.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41688&comment_hash=6df5ece2301c9c7503042157975621155b60c01ce1ca9f300c6ded221ff7018f&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41688&comment_hash=6df5ece2301c9c7503042157975621155b60c01ce1ca9f300c6ded221ff7018f&reaction=dislike'>👎</a>
##########
superset/translations/fr/LC_MESSAGES/messages.po:
##########
@@ -4829,68 +4758,68 @@ msgid "Databases"
msgstr "Bases de données"
msgid "Dataset"
-msgstr "Ensemble de données"
+msgstr "Jeu de données"
#, python-format
msgid "Dataset %(table)s already exists"
msgstr "Le jeu de données %(table)s existe déjà"
msgid "Dataset Name"
-msgstr "Nom de l’ensemble de données"
+msgstr "Nom du jeu de données"
msgid "Dataset column delete failed."
-msgstr "La suppression de l’ensemble de données a échoué."
+msgstr "La suppression du jeu de données a échoué."
Review Comment:
**Suggestion:** This translation drops the “column” scope and says the whole
dataset deletion failed, which is a different operation and can confuse
remediation steps. Keep the wording specific to dataset column deletion.
[comment mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
⚠️ Column delete errors misreported as dataset deletion failures.
⚠️ Users misdiagnose dataset instead of column problems.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. In `superset/commands/dataset/columns/exceptions.py:3-8`, the class
`DatasetColumnDeleteFailedError` sets its message to `_("Dataset column
delete failed.")`.
2. The dataset column delete API at `superset/datasets/columns/api.py:13-27`
catches
`DatasetColumnDeleteFailedError` and returns a 422 response with
`message=str(ex)`, which
is the localized message.
3. In the French catalog at
`superset/translations/fr/LC_MESSAGES/messages.po:4770-4771`,
the msgid `Dataset column delete failed.` is translated as `La suppression
du jeu de
données a échoué.`, dropping the word "column".
4. When a dataset column deletion fails in the UI (Edit datasource >
Columns), French
users see an error saying the dataset deletion failed, which misstates the
operation and
can misdirect troubleshooting.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=ce982ea4548a49bbbdb52d0b85c9f07e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=ce982ea4548a49bbbdb52d0b85c9f07e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/fr/LC_MESSAGES/messages.po
**Line:** 4771:4771
**Comment:**
*Comment Mismatch: This translation drops the “column” scope and says
the whole dataset deletion failed, which is a different operation and can
confuse remediation steps. Keep the wording specific to dataset column deletion.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41688&comment_hash=8486c9dead2cb16ecf0d8eddbc6b572d68ada282f28bf7dfaeb35fd4fe659218&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41688&comment_hash=8486c9dead2cb16ecf0d8eddbc6b572d68ada282f28bf7dfaeb35fd4fe659218&reaction=dislike'>👎</a>
##########
superset/translations/fr/LC_MESSAGES/messages.po:
##########
@@ -4829,68 +4758,68 @@ msgid "Databases"
msgstr "Bases de données"
msgid "Dataset"
-msgstr "Ensemble de données"
+msgstr "Jeu de données"
#, python-format
msgid "Dataset %(table)s already exists"
msgstr "Le jeu de données %(table)s existe déjà"
msgid "Dataset Name"
-msgstr "Nom de l’ensemble de données"
+msgstr "Nom du jeu de données"
msgid "Dataset column delete failed."
-msgstr "La suppression de l’ensemble de données a échoué."
+msgstr "La suppression du jeu de données a échoué."
msgid "Dataset column not found."
-msgstr "Colonne de l’ensemble de données introuvable."
+msgstr "Colonne du jeu de données introuvable."
msgid "Dataset could not be created."
-msgstr "L’ensemble de données n'a pas pu être créé."
+msgstr "Le jeu de données n'a pas pu être créé."
msgid "Dataset could not be duplicated."
-msgstr "L’ensemble de données n'a pas pu être dupliqué."
+msgstr "Le jeu de données n'a pas pu être dupliqué."
msgid "Dataset could not be updated."
-msgstr "L’ensemble de données n'a pas pu être mis à jour."
+msgstr "Le jeu de données n'a pas pu être mis à jour."
msgid "Dataset does not exist"
-msgstr "L’ensemble de données n'existe pas"
+msgstr "Le jeu de données n'existe pas"
msgid "Dataset is required"
-msgstr "Un ensemble de données est requis"
+msgstr "Un jeu de données est requis"
msgid "Dataset metric delete failed."
-msgstr "La suppression de l’ensemble de données a échoué."
+msgstr "La suppression du jeu de données a échoué."
msgid "Dataset metric not found."
-msgstr "Mesure de l'ensemble de données non trouvée."
+msgstr "Mesure du jeu de données non trouvée."
msgid "Dataset name"
-msgstr "Nom de l’ensemble de données"
+msgstr "Nom du jeu de données"
msgid "Dataset parameters are invalid."
-msgstr "Les paramètres de l'ensemble de données ne sont pas valides."
+msgstr "Les paramètres du jeu de données ne sont pas valides."
#, python-format
msgid "Dataset schema is invalid, caused by: %(error)s"
-msgstr "Le schéma de l'ensemble de données n'est pas valide : %(error)s"
+msgstr "Le schéma du jeu de données n'est pas valide : %(error)s"
Review Comment:
**Suggestion:** The translation for an SQL parsing error now says the
dataset schema is invalid, which mismatches the original message intent and
will mislead users during debugging. Update this translation to refer to SQL
validity, not dataset schema validity. [comment mismatch]
<details>
<summary><b>Severity Level:</b> Minor 🧹</summary>
```mdx
⚠️ Suggestion addresses non-issue; translation already correct.
⚠️ Changing text would misalign dataset schema error.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Inspect the French catalog at
`superset/translations/fr/LC_MESSAGES/messages.po:4804-4805`, where the
English msgid is
`Dataset schema is invalid, caused by: %(error)s` and the French msgstr is
`Le schéma du
jeu de données n'est pas valide : %(error)s`.
2. Note that the English source string itself refers to "Dataset schema",
not SQL parsing,
and is consistent with similar translations in other locales (verified via
Grep on
`Dataset schema is invalid, caused by`).
3. There is no alternative English msgid about SQL validity bound to this
translation; the
only bound msgid at `messages.po:4804` is the dataset schema error.
4. Changing the French translation to mention SQL validity would diverge
from the actual
msgid semantics, so the existing translation is already correct and the
suggestion targets
a non-issue.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9d81bcab48b84e8ca6c389a953b83757&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9d81bcab48b84e8ca6c389a953b83757&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/fr/LC_MESSAGES/messages.po
**Line:** 4805:4805
**Comment:**
*Comment Mismatch: The translation for an SQL parsing error now says
the dataset schema is invalid, which mismatches the original message intent and
will mislead users during debugging. Update this translation to refer to SQL
validity, not dataset schema validity.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41688&comment_hash=44be2a74a3c4b411afc7e6fca4f43e647fa26b2741e9040f04578b96c7f40b5c&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41688&comment_hash=44be2a74a3c4b411afc7e6fca4f43e647fa26b2741e9040f04578b96c7f40b5c&reaction=dislike'>👎</a>
##########
superset/translations/fr/LC_MESSAGES/messages.po:
##########
@@ -6435,39 +6316,35 @@ msgstr "Taille des dates égales"
msgid "Equal to (=)"
msgstr "Égal à (=)"
-#, fuzzy
msgid "Equals"
msgstr "Egal"
msgid "Error"
msgstr "Erreur"
-#, fuzzy
msgid "Error Fetching Tagged Objects"
msgstr ""
-"Désolé, une erreur s'est produite lors de la récupération des "
-"informations de cette base de données : %s"
+"Une erreur s'est produite lors de la récupération des objets par tag"
-#, fuzzy, python-format
+#, python-format
msgid "Error deleting %s"
-msgstr "Une erreur s'est produite durant la récupération des données : %s"
+msgstr "Erreur à la suppression de %s"
# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, es, sr,
# sr_Latn]
-#, fuzzy, python-format
+#, python-format
msgid "Error disabling fullscreen: %s"
msgstr "Erreur lors de la désactivation du plein écran : %s"
-#, fuzzy, python-format
+#, python-format
msgid "Error enabling fullscreen: %s"
-msgstr "Une erreur s'est produite durant la récupération des données : %s"
+msgstr "Une erreur s'est produite durant l'activation du plein écran' : %s"
msgid "Error executing query. "
msgstr "Erreur lors de l'exécution d'une requête."
-#, fuzzy
msgid "Error faving chart"
-msgstr "Une erreur s'est produite durant la sauvegarde du jeu de données"
+msgstr "Une erreur s'est produite durant la sauvegarde du graphique"
Review Comment:
**Suggestion:** The source message is about failing to favorite a chart, but
the translation says chart save failed, which is a different action and can
send users to the wrong workflow. Translate it to a “favorite” failure message.
[comment mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
⚠️ Favorite failures shown as save failures to users.
⚠️ Users troubleshoot saving instead of favoriting errors.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. When a user favorites a chart, Superset executes
`AddFavoriteChartCommand.run()` in
`superset/commands/chart/fave.py:2-12`, wrapped in a transaction with
`on_error=ChartFaveError`.
2. The `ChartFaveError` exception in
`superset/commands/chart/exceptions.py:159-160` sets
its message to `_("Error faving chart")`, which is surfaced back to the
client on failure.
3. In the French catalog at
`superset/translations/fr/LC_MESSAGES/messages.po:6346-6347`,
msgid `Error faving chart` is translated as `Une erreur s'est produite
durant la
sauvegarde du graphique`, which describes a save failure instead of a
favorite failure.
4. As a result, French users encountering errors while marking a chart as
favorite see a
message about saving, which points them toward the wrong workflow and
obscures
favorite-specific issues (permissions, backend errors).
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=569868c1da8e4fdba3ee1d93f63bc160&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=569868c1da8e4fdba3ee1d93f63bc160&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/fr/LC_MESSAGES/messages.po
**Line:** 6347:6347
**Comment:**
*Comment Mismatch: The source message is about failing to favorite a
chart, but the translation says chart save failed, which is a different action
and can send users to the wrong workflow. Translate it to a “favorite” failure
message.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41688&comment_hash=a2bed24f31a1f7339d8b78fd69d95a18948627c1483f156fca271ab2b6ec5777&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41688&comment_hash=a2bed24f31a1f7339d8b78fd69d95a18948627c1483f156fca271ab2b6ec5777&reaction=dislike'>👎</a>
##########
superset/translations/fr/LC_MESSAGES/messages.po:
##########
@@ -13941,9 +13648,9 @@ msgstr "Sous-total"
msgid "Success"
msgstr "Réussite"
-#, fuzzy, python-format
+#, python-format
msgid "Successfully changed %s!"
-msgstr "Ensemble de données modifé avec succès"
+msgstr "%s modifé avec succès !"
Review Comment:
**Suggestion:** There is an obvious typo in the translated success message
(“modifé”). Correct it to the proper French spelling to avoid low-quality UI
text. [typo]
<details>
<summary><b>Severity Level:</b> Minor 🧹</summary>
```mdx
⚠️ Success toast shows misspelt French verb “modifé”.
⚠️ Minor localization quality issue in datasource change modal.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. The Change Datasource modal in
`superset-frontend/src/components/Datasource/ChangeDatasourceModal/index.tsx:5-15`
calls
`addSuccessToast(t('Successfully changed %s!', datasetLabelLower()))` after
a successful
dataset change.
2. The English msgid `Successfully changed %s!` is bound in the French
catalog at
`superset/translations/fr/LC_MESSAGES/messages.po:13652-13653` to msgstr `%s
modifé avec
succès !`.
3. The verb form `modifé` is misspelled in French (correct form: `modifié`),
so every
successful datasource change with French locale active shows this typo in
the success
toast.
4. This repeatedly exposes a localization error in a common success path,
slightly
degrading perceived polish and quality of the French UI.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e82fc623cc744e8c9031b060bde7b146&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e82fc623cc744e8c9031b060bde7b146&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/fr/LC_MESSAGES/messages.po
**Line:** 13653:13653
**Comment:**
*Typo: There is an obvious typo in the translated success message
(“modifé”). Correct it to the proper French spelling to avoid low-quality UI
text.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41688&comment_hash=9f8a2982e81aa05a30fc0cf892edf89d4a028e67ad4bc854117f6a85d782b9f4&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41688&comment_hash=9f8a2982e81aa05a30fc0cf892edf89d4a028e67ad4bc854117f6a85d782b9f4&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
