codeant-ai-for-open-source[bot] commented on code in PR #41688:
URL: https://github.com/apache/superset/pull/41688#discussion_r3518421118
##########
superset/translations/fr/LC_MESSAGES/messages.po:
##########
@@ -9655,7 +9463,7 @@ msgid "No %s yet"
msgstr "Pas encore de %s"
msgid "No Data"
-msgstr "Aucune donnée"
+msgstr "Non applicable"
Review Comment:
**Suggestion:** The source key means "No Data", but the translation says
"Not applicable", which is a different state. This can miscommunicate system
status to users when queries return empty results. Use a direct "no data"
translation. [comment mismatch]
<details>
<summary><b>Severity Level:</b> Critical 🚨</summary>
```mdx
❌ Empty table state miscommunicated as not applicable.
⚠️ Users misinterpret filter or data availability issues.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. In the French catalog at
`superset/translations/fr/LC_MESSAGES/messages.po:9464-9467`,
the entry `msgid "No Data"` is translated as `msgstr "Non applicable"` on
line 9466.
2. In the frontend list view component
`superset-frontend/src/components/ListView/ListView.tsx:643-647`, the empty
state title is
set to `emptyState?.title || t('No Data')`, so whenever a list has no rows,
the UI shows
the translation for `"No Data"`.
3. Additional usages of the “No Data” concept appear in tooltip and matrix
components, for
example in
`superset-frontend/packages/superset-ui-core/test/chart-composition/tooltip/TooltipTable.test.tsx:39`
which asserts that empty tooltips show `/No Data|empty/i`, and in matrix
grid tests
asserting “Custom No Data Message.”
4. Because the French translation maps “No Data” to “Non applicable” instead
of a direct
“Aucune donnée” style wording, users seeing empty lists, charts, or tooltips
will be told
the feature is “not applicable” rather than simply that there is currently
no data,
miscommunicating the state of filters or data availability.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=118a4de65a7d4d76992ec3a4eba20539&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=118a4de65a7d4d76992ec3a4eba20539&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/fr/LC_MESSAGES/messages.po
**Line:** 9466:9466
**Comment:**
*Comment Mismatch: The source key means "No Data", but the translation
says "Not applicable", which is a different state. This can miscommunicate
system status to users when queries return empty results. Use a direct "no
data" translation.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41688&comment_hash=69513311c889a8b54ed2a808d25b29c3832e3141321127efa2001accd9428945&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41688&comment_hash=69513311c889a8b54ed2a808d25b29c3832e3141321127efa2001accd9428945&reaction=dislike'>👎</a>
##########
superset/translations/fr/LC_MESSAGES/messages.po:
##########
@@ -6881,17 +6753,15 @@ msgstr "Échec lors de la récupération des résultats"
msgid "Failed to apply theme: Invalid JSON"
msgstr "Échec de l'application du thème : JSON invalide"
-#, fuzzy
+
msgid "Failed to copy API key to clipboard"
-msgstr "Copier la requête de partition vers le presse-papier"
+msgstr "Échec lors de la copie de la clé d'API vers le presse-papier"
-#, fuzzy
msgid "Failed to copy stack trace to clipboard"
-msgstr "Copier vers le presse-papier"
+msgstr "Copier le message d'erreur vers le presse-papier"
Review Comment:
**Suggestion:** This translation turns a failure message into an imperative
instruction ("Copy..."), which reverses the meaning and drops the failure
context. Users will not understand that the copy operation failed. Translate it
as an explicit copy failure message. [comment mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
⚠️ Task stack trace copy failures misreported to users.
⚠️ Users think copy succeeded, lose diagnostic information.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. In the frontend file
`superset-frontend/src/features/tasks/TaskStackTracePopover.tsx:98-102`, the
stack trace
copy handler catches failures from `navigator.clipboard.writeText` and calls
`addDangerToast(t('Failed to copy stack trace to clipboard'));` at line 100.
2. This `msgid "Failed to copy stack trace to clipboard"` is extracted into
the i18n
catalog and in French appears at
`superset/translations/fr/LC_MESSAGES/messages.po:6759-6761`, where it is
translated as
`msgstr "Copier le message d'erreur vers le presse-papier"`.
3. The French translation is imperative (“Copy the error message to the
clipboard”) and
drops the failure context, instead of indicating that the copy operation
failed as the
English source string does.
4. When a user clicks “Copy stack trace” and the clipboard API fails (for
example due to
browser permissions), the UI will show a danger toast in French that reads
like a command
rather than an error, confusing users about whether the copy succeeded or
failed.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5f94f0bbf1324073a1a7cd51334280ac&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5f94f0bbf1324073a1a7cd51334280ac&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/fr/LC_MESSAGES/messages.po
**Line:** 6761:6761
**Comment:**
*Comment Mismatch: This translation turns a failure message into an
imperative instruction ("Copy..."), which reverses the meaning and drops the
failure context. Users will not understand that the copy operation failed.
Translate it as an explicit copy failure message.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41688&comment_hash=5bcd609efea39b739407a672d8d54d343c8d3acd47c85e53a1119e50cd698726&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41688&comment_hash=5bcd609efea39b739407a672d8d54d343c8d3acd47c85e53a1119e50cd698726&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
