rusackas commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3525750991
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts:
##########
@@ -471,19 +471,19 @@ export function applyAdvancedTimeRangeFilterOnDashboard(
endRange?: string,
) {
cy.get('.control-label').contains('Range type').should('be.visible');
- cy.get('.ant-popover-content .ant-select-selector')
+ cy.get('.ant-popover-content .ant-select-content')
.should('be.visible')
.click();
cy.get(`[label="Advanced"]`).should('be.visible').click();
cy.get('.section-title').contains('Advanced Time
Range').should('be.visible');
if (startRange) {
- cy.get('.ant-popover-inner-content')
+ cy.get('.ant-popover-content')
.find('[class^=ant-input]')
.first()
.type(`${startRange}`);
Review Comment:
These are existing Cypress helpers just being updated for the antd6
class-name changes, not new coverage. Wholesale Cypress→Playwright migration is
its own effort, out of scope for the upgrade.
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts:
##########
@@ -471,19 +471,19 @@ export function applyAdvancedTimeRangeFilterOnDashboard(
endRange?: string,
) {
cy.get('.control-label').contains('Range type').should('be.visible');
- cy.get('.ant-popover-content .ant-select-selector')
+ cy.get('.ant-popover-content .ant-select-content')
.should('be.visible')
.click();
cy.get(`[label="Advanced"]`).should('be.visible').click();
cy.get('.section-title').contains('Advanced Time
Range').should('be.visible');
if (startRange) {
- cy.get('.ant-popover-inner-content')
+ cy.get('.ant-popover-content')
.find('[class^=ant-input]')
.first()
.type(`${startRange}`);
}
if (endRange) {
- cy.get('.ant-popover-inner-content')
+ cy.get('.ant-popover-content')
.find('[class^=ant-input]')
.last()
.type(`${endRange}`);
Review Comment:
Same as above — existing helper, only the antd6 selector changed. Migrating
the Cypress suite to Playwright is a separate effort, not part of this upgrade.
##########
superset-frontend/cypress-base/cypress/support/directories.ts:
##########
@@ -52,7 +52,7 @@ export const securityAccess = {
};
export const homePage = {
homeSection: {
- sectionArea: '.ant-collapse-content-box',
+ sectionArea: '.ant-collapse-body',
Review Comment:
This is an existing selector in the Cypress support file updated for the
antd6 class rename, not new e2e coverage. Playwright migration is out of scope
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
