codeant-ai-for-open-source[bot] commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3525751839
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts:
##########
@@ -471,19 +471,19 @@ export function applyAdvancedTimeRangeFilterOnDashboard(
endRange?: string,
) {
cy.get('.control-label').contains('Range type').should('be.visible');
- cy.get('.ant-popover-content .ant-select-selector')
+ cy.get('.ant-popover-content .ant-select-content')
.should('be.visible')
.click();
cy.get(`[label="Advanced"]`).should('be.visible').click();
cy.get('.section-title').contains('Advanced Time
Range').should('be.visible');
if (startRange) {
- cy.get('.ant-popover-inner-content')
+ cy.get('.ant-popover-content')
.find('[class^=ant-input]')
.first()
.type(`${startRange}`);
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not suggest migrating existing Cypress helper updates to Playwright
when the change is only maintaining existing Cypress e2e utilities; wholesale
Cypress-to-Playwright migration should be treated as out of scope for these
files.
**Applied to:**
- `superset-frontend/cypress-base/cypress/**`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
##########
superset-frontend/cypress-base/cypress/support/directories.ts:
##########
@@ -52,7 +52,7 @@ export const securityAccess = {
};
export const homePage = {
homeSection: {
- sectionArea: '.ant-collapse-content-box',
+ sectionArea: '.ant-collapse-body',
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag existing selector updates in Cypress support files as new e2e
coverage; Playwright migration suggestions are out of scope for selector
renames in this folder.
**Applied to:**
- `superset-frontend/cypress-base/cypress/support/**`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
